How safe do you think this is to backport? It looks like the Linux code does the same thing, so we shouldn't break any more pages but I'm not sure if the Mac code path would be much different. > Thanks, Mehdi, for fixing this longstanding bug! It should read "Let the superclass do the > I do have one nit to pick: The "let the superview do context menu > original reason for this check is lost in the mists of time. And (as Mehdi pointed out in comment #34) the > Cocoa widgets, no other mouse event gets checked for whether or not > right-click was handled before bringing up a context menu. > But Mehdi's found that other platforms don't check whether or not a > telling us that the right-click wasn't handled. > ultimately the cause of this bug - Google Maps must (presumably) be ![]() They stated the block could take anywhere from 24hrs to days or even weeks. I had spoken to Technical Support for our ISP and Router Provider which said it could be a temporary block by Google. Google Earth started working a couple of days later. > whether or not a given event was handled, and I suppose that's Yes I tried all of the steps listed in the article you linked. > We've always had problems getting getting reliable information about > Remove safety check before bringing up menu. ![]() I didn't stress test it on other cases though. Of course, I tested the code on Google Maps, and it provides the expected behaviour. ![]() Turns out it has been there from the start:įurthermore, I looked at code in the windows widget and it seems like they call DispatchWindowEvent (a similar version) without worrying about the result. |menuForEvent:| is not being called because |rightMouseDown| adds a safety check to DispatchWindowEvent (presumably to avoid double handling the event).įirst I tried understanding why the status was being set but after this proved useless, I removed the check and looked for its origin. (when the click is made by a control+click, |menuForEvent:| is actually called by the super, and it calls |mouseDown:|.) Splinter Review After looking at the problem, it turns out that |menuforEvent:| (in cocoa/nsChildView) is not being called when the mouse is being right-clicked. Remove safety check before bringing up menu.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |